From 91a4a13ed1bfe1f4aa4f375242d3c45401bcde22 Mon Sep 17 00:00:00 2001 From: Joris Bayer Date: Sun, 18 Feb 2024 17:35:43 +0100 Subject: [PATCH] Fix panic for REPLACE --- src/parser/mod.rs | 40 +++++++++++++++++++++++++++++++++++++++- 1 file changed, 39 insertions(+), 1 deletion(-) diff --git a/src/parser/mod.rs b/src/parser/mod.rs index c2397c74ab..55e49b6dda 100644 --- a/src/parser/mod.rs +++ b/src/parser/mod.rs @@ -7894,7 +7894,7 @@ impl<'a> Parser<'a> { return parser_err!("Unsupported statement REPLACE", self.peek_token().location); } - let insert = &mut self.parse_insert().unwrap(); + let insert = &mut self.parse_insert()?; if let Statement::Insert { replace_into, .. } = insert { *replace_into = true; } @@ -9662,4 +9662,42 @@ mod tests { panic!("fail to parse mysql partition selection"); } } + + #[test] + fn test_replace_into_placeholders() { + let sql = "REPLACE INTO t (a) VALUES (&a)"; + + assert!(Parser::parse_sql(&GenericDialect {}, sql).is_err()); + } + + #[test] + fn test_replace_into_set() { + // NOTE: This is actually valid MySQL syntax, REPLACE and INSERT, + // but the parser does not yet support it. + // https://dev.mysql.com/doc/refman/8.3/en/insert.html + let sql = "REPLACE INTO t SET a='1'"; + + assert!(Parser::parse_sql(&MySqlDialect {}, sql).is_err()); + } + + #[test] + fn test_replace_into_set_placeholder() { + let sql = "REPLACE INTO t SET ?"; + + assert!(Parser::parse_sql(&GenericDialect {}, sql).is_err()); + } + + #[test] + fn test_replace_into_select() { + let sql = r#"REPLACE INTO t1 (a, b, c) (SELECT * FROM t2)"#; + + assert!(Parser::parse_sql(&GenericDialect {}, sql).is_err()); + } + + #[test] + fn test_replace_incomplete() { + let sql = r#"REPLACE"#; + + assert!(Parser::parse_sql(&MySqlDialect {}, sql).is_err()); + } }