From 08b116638fdcd6af090bb42b66a62f75666f85f7 Mon Sep 17 00:00:00 2001 From: "sentry-junior[bot]" <264270552+sentry-junior[bot]@users.noreply.github.com> Date: Thu, 12 Nov 2026 11:03:57 +0000 Subject: [PATCH] fix(mcp): Tell agents to send feedback only for Sentry MCP problems Two agents filed reports through submit_feedback_to_sentry_team that described no problem: one logged a skipped step (MCP-SERVER-GNZ) and one announced a shell task that never needed Sentry (MCP-SERVER-GP0). The hint "call at most once per task, after you finish or give up" reads as "call it at the end of every task", and "no Sentry MCP tool could do what the user asked" covers any non-Sentry task. Say the tool is only for a Sentry MCP tool that was missing, failed, or got in the way, and to skip it when the task went fine, was skipped, or did not need Sentry. Refs #2169 --- packages/mcp-core/src/skillDefinitions.json | 10 +++++----- packages/mcp-core/src/toolDefinitions.json | 2 +- .../submit-feedback-to-sentry-team.test.ts | 16 ++++++++++++++++ .../catalog/submit-feedback-to-sentry-team.ts | 8 ++++---- 4 files changed, 26 insertions(+), 10 deletions(-) diff --git a/packages/mcp-core/src/skillDefinitions.json b/packages/mcp-core/src/skillDefinitions.json index 0ac7ed310..8c9257566 100644 --- a/packages/mcp-core/src/skillDefinitions.json +++ b/packages/mcp-core/src/skillDefinitions.json @@ -239,7 +239,7 @@ }, { "name": "submit_feedback_to_sentry_team", - "description": "Report friction with the Sentry MCP server to its maintainers.\n\nUse this tool when you need to:\n- Report that no Sentry MCP tool could do what the user asked\n- Report a tool that failed, returned wrong data, or was confusing\n- Suggest an improvement to the Sentry MCP tools\n\n\nsubmit_feedback_to_sentry_team(task='find slow endpoints', kind='missing', impact='blocked', description='No tool returns p95 latency per endpoint.')\n\n\n\n- Call at most once per task, after you finish or give up.\n- Only call it with a real report. Do not call it to test it.\n- Feedback goes to the Sentry MCP maintainers, not the user's Sentry organization.\n- Do not include secrets, credentials, or personal data.\n", + "description": "Report friction with the Sentry MCP server to its maintainers.\n\nUse this tool when you need to:\n- Report that no Sentry MCP tool could do a Sentry task the user asked for\n- Report a Sentry MCP tool that failed, returned wrong data, or was confusing\n- Suggest an improvement to the Sentry MCP tools\n\n\nsubmit_feedback_to_sentry_team(task='find slow endpoints', kind='missing', impact='blocked', description='No tool returns p95 latency per endpoint.')\n\n\n\n- Call it only when a Sentry MCP tool was missing, failed, or got in the way, at most once per task.\n- Skip it if the task went fine, was skipped, or did not need Sentry. Do not use it to log progress or to test it.\n- Feedback goes to the Sentry MCP maintainers, not the user's Sentry organization.\n- Do not include secrets, credentials, or personal data.\n", "requiredScopes": [] }, { @@ -339,7 +339,7 @@ }, { "name": "submit_feedback_to_sentry_team", - "description": "Report friction with the Sentry MCP server to its maintainers.\n\nUse this tool when you need to:\n- Report that no Sentry MCP tool could do what the user asked\n- Report a tool that failed, returned wrong data, or was confusing\n- Suggest an improvement to the Sentry MCP tools\n\n\nsubmit_feedback_to_sentry_team(task='find slow endpoints', kind='missing', impact='blocked', description='No tool returns p95 latency per endpoint.')\n\n\n\n- Call at most once per task, after you finish or give up.\n- Only call it with a real report. Do not call it to test it.\n- Feedback goes to the Sentry MCP maintainers, not the user's Sentry organization.\n- Do not include secrets, credentials, or personal data.\n", + "description": "Report friction with the Sentry MCP server to its maintainers.\n\nUse this tool when you need to:\n- Report that no Sentry MCP tool could do a Sentry task the user asked for\n- Report a Sentry MCP tool that failed, returned wrong data, or was confusing\n- Suggest an improvement to the Sentry MCP tools\n\n\nsubmit_feedback_to_sentry_team(task='find slow endpoints', kind='missing', impact='blocked', description='No tool returns p95 latency per endpoint.')\n\n\n\n- Call it only when a Sentry MCP tool was missing, failed, or got in the way, at most once per task.\n- Skip it if the task went fine, was skipped, or did not need Sentry. Do not use it to log progress or to test it.\n- Feedback goes to the Sentry MCP maintainers, not the user's Sentry organization.\n- Do not include secrets, credentials, or personal data.\n", "requiredScopes": [] }, { @@ -385,7 +385,7 @@ }, { "name": "submit_feedback_to_sentry_team", - "description": "Report friction with the Sentry MCP server to its maintainers.\n\nUse this tool when you need to:\n- Report that no Sentry MCP tool could do what the user asked\n- Report a tool that failed, returned wrong data, or was confusing\n- Suggest an improvement to the Sentry MCP tools\n\n\nsubmit_feedback_to_sentry_team(task='find slow endpoints', kind='missing', impact='blocked', description='No tool returns p95 latency per endpoint.')\n\n\n\n- Call at most once per task, after you finish or give up.\n- Only call it with a real report. Do not call it to test it.\n- Feedback goes to the Sentry MCP maintainers, not the user's Sentry organization.\n- Do not include secrets, credentials, or personal data.\n", + "description": "Report friction with the Sentry MCP server to its maintainers.\n\nUse this tool when you need to:\n- Report that no Sentry MCP tool could do a Sentry task the user asked for\n- Report a Sentry MCP tool that failed, returned wrong data, or was confusing\n- Suggest an improvement to the Sentry MCP tools\n\n\nsubmit_feedback_to_sentry_team(task='find slow endpoints', kind='missing', impact='blocked', description='No tool returns p95 latency per endpoint.')\n\n\n\n- Call it only when a Sentry MCP tool was missing, failed, or got in the way, at most once per task.\n- Skip it if the task went fine, was skipped, or did not need Sentry. Do not use it to log progress or to test it.\n- Feedback goes to the Sentry MCP maintainers, not the user's Sentry organization.\n- Do not include secrets, credentials, or personal data.\n", "requiredScopes": [] }, { @@ -515,7 +515,7 @@ }, { "name": "submit_feedback_to_sentry_team", - "description": "Report friction with the Sentry MCP server to its maintainers.\n\nUse this tool when you need to:\n- Report that no Sentry MCP tool could do what the user asked\n- Report a tool that failed, returned wrong data, or was confusing\n- Suggest an improvement to the Sentry MCP tools\n\n\nsubmit_feedback_to_sentry_team(task='find slow endpoints', kind='missing', impact='blocked', description='No tool returns p95 latency per endpoint.')\n\n\n\n- Call at most once per task, after you finish or give up.\n- Only call it with a real report. Do not call it to test it.\n- Feedback goes to the Sentry MCP maintainers, not the user's Sentry organization.\n- Do not include secrets, credentials, or personal data.\n", + "description": "Report friction with the Sentry MCP server to its maintainers.\n\nUse this tool when you need to:\n- Report that no Sentry MCP tool could do a Sentry task the user asked for\n- Report a Sentry MCP tool that failed, returned wrong data, or was confusing\n- Suggest an improvement to the Sentry MCP tools\n\n\nsubmit_feedback_to_sentry_team(task='find slow endpoints', kind='missing', impact='blocked', description='No tool returns p95 latency per endpoint.')\n\n\n\n- Call it only when a Sentry MCP tool was missing, failed, or got in the way, at most once per task.\n- Skip it if the task went fine, was skipped, or did not need Sentry. Do not use it to log progress or to test it.\n- Feedback goes to the Sentry MCP maintainers, not the user's Sentry organization.\n- Do not include secrets, credentials, or personal data.\n", "requiredScopes": [] }, { @@ -635,7 +635,7 @@ }, { "name": "submit_feedback_to_sentry_team", - "description": "Report friction with the Sentry MCP server to its maintainers.\n\nUse this tool when you need to:\n- Report that no Sentry MCP tool could do what the user asked\n- Report a tool that failed, returned wrong data, or was confusing\n- Suggest an improvement to the Sentry MCP tools\n\n\nsubmit_feedback_to_sentry_team(task='find slow endpoints', kind='missing', impact='blocked', description='No tool returns p95 latency per endpoint.')\n\n\n\n- Call at most once per task, after you finish or give up.\n- Only call it with a real report. Do not call it to test it.\n- Feedback goes to the Sentry MCP maintainers, not the user's Sentry organization.\n- Do not include secrets, credentials, or personal data.\n", + "description": "Report friction with the Sentry MCP server to its maintainers.\n\nUse this tool when you need to:\n- Report that no Sentry MCP tool could do a Sentry task the user asked for\n- Report a Sentry MCP tool that failed, returned wrong data, or was confusing\n- Suggest an improvement to the Sentry MCP tools\n\n\nsubmit_feedback_to_sentry_team(task='find slow endpoints', kind='missing', impact='blocked', description='No tool returns p95 latency per endpoint.')\n\n\n\n- Call it only when a Sentry MCP tool was missing, failed, or got in the way, at most once per task.\n- Skip it if the task went fine, was skipped, or did not need Sentry. Do not use it to log progress or to test it.\n- Feedback goes to the Sentry MCP maintainers, not the user's Sentry organization.\n- Do not include secrets, credentials, or personal data.\n", "requiredScopes": [] }, { diff --git a/packages/mcp-core/src/toolDefinitions.json b/packages/mcp-core/src/toolDefinitions.json index 62a8e6e1f..85faf0a6a 100644 --- a/packages/mcp-core/src/toolDefinitions.json +++ b/packages/mcp-core/src/toolDefinitions.json @@ -13770,7 +13770,7 @@ { "name": "submit_feedback_to_sentry_team", "title": "Submit Feedback to Sentry Team", - "description": "Report friction with the Sentry MCP server to its maintainers.\n\nUse this tool when you need to:\n- Report that no Sentry MCP tool could do what the user asked\n- Report a tool that failed, returned wrong data, or was confusing\n- Suggest an improvement to the Sentry MCP tools\n\n\nsubmit_feedback_to_sentry_team(task='find slow endpoints', kind='missing', impact='blocked', description='No tool returns p95 latency per endpoint.')\n\n\n\n- Call at most once per task, after you finish or give up.\n- Only call it with a real report. Do not call it to test it.\n- Feedback goes to the Sentry MCP maintainers, not the user's Sentry organization.\n- Do not include secrets, credentials, or personal data.\n", + "description": "Report friction with the Sentry MCP server to its maintainers.\n\nUse this tool when you need to:\n- Report that no Sentry MCP tool could do a Sentry task the user asked for\n- Report a Sentry MCP tool that failed, returned wrong data, or was confusing\n- Suggest an improvement to the Sentry MCP tools\n\n\nsubmit_feedback_to_sentry_team(task='find slow endpoints', kind='missing', impact='blocked', description='No tool returns p95 latency per endpoint.')\n\n\n\n- Call it only when a Sentry MCP tool was missing, failed, or got in the way, at most once per task.\n- Skip it if the task went fine, was skipped, or did not need Sentry. Do not use it to log progress or to test it.\n- Feedback goes to the Sentry MCP maintainers, not the user's Sentry organization.\n- Do not include secrets, credentials, or personal data.\n", "inputSchema": { "type": "object", "properties": { diff --git a/packages/mcp-core/src/tools/catalog/submit-feedback-to-sentry-team.test.ts b/packages/mcp-core/src/tools/catalog/submit-feedback-to-sentry-team.test.ts index ebf027267..43eb9a773 100644 --- a/packages/mcp-core/src/tools/catalog/submit-feedback-to-sentry-team.test.ts +++ b/packages/mcp-core/src/tools/catalog/submit-feedback-to-sentry-team.test.ts @@ -66,6 +66,22 @@ describe("submit_feedback_to_sentry_team", () => { ); }); + // MCP-SERVER-GNZ logged a skipped step ("No fue necesario; se omite.") and + // MCP-SERVER-GP0 announced a shell task ("checking for running Podman + // containers") that never needed Sentry. Neither reported a problem, and + // no word list catches them, so the description has to rule them out. + it("tells agents to call it only for Sentry MCP problems", () => { + const { description } = submitFeedbackToSentryTeam; + + expect(description).not.toContain("after you finish or give up"); + expect(description).toContain( + "Call it only when a Sentry MCP tool was missing, failed, or got in the way", + ); + expect(description).toContain( + "Skip it if the task went fine, was skipped, or did not need Sentry.", + ); + }); + // MCP-SERVER-GNB, GMP and GK1 were filler-only reports from three clients. it.each(["placeholder", "N/A", "noop", " ... "])( "rejects the placeholder description %j", diff --git a/packages/mcp-core/src/tools/catalog/submit-feedback-to-sentry-team.ts b/packages/mcp-core/src/tools/catalog/submit-feedback-to-sentry-team.ts index 7be28e388..62953cda9 100644 --- a/packages/mcp-core/src/tools/catalog/submit-feedback-to-sentry-team.ts +++ b/packages/mcp-core/src/tools/catalog/submit-feedback-to-sentry-team.ts @@ -60,8 +60,8 @@ export default defineTool({ "Report friction with the Sentry MCP server to its maintainers.", "", "Use this tool when you need to:", - "- Report that no Sentry MCP tool could do what the user asked", - "- Report a tool that failed, returned wrong data, or was confusing", + "- Report that no Sentry MCP tool could do a Sentry task the user asked for", + "- Report a Sentry MCP tool that failed, returned wrong data, or was confusing", "- Suggest an improvement to the Sentry MCP tools", "", "", @@ -69,8 +69,8 @@ export default defineTool({ "", "", "", - "- Call at most once per task, after you finish or give up.", - "- Only call it with a real report. Do not call it to test it.", + "- Call it only when a Sentry MCP tool was missing, failed, or got in the way, at most once per task.", + "- Skip it if the task went fine, was skipped, or did not need Sentry. Do not use it to log progress or to test it.", "- Feedback goes to the Sentry MCP maintainers, not the user's Sentry organization.", "- Do not include secrets, credentials, or personal data.", "",