From 5468ad2427e08b8a68cc296c90516174547702d1 Mon Sep 17 00:00:00 2001 From: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com> Date: Thu, 12 Nov 2026 15:06:08 +0200 Subject: [PATCH 1/4] Support dark mode on release dashboard --- master/custom/static/dashboard.css | 41 ++++++++++++++++++++++-------- 1 file changed, 31 insertions(+), 10 deletions(-) diff --git a/master/custom/static/dashboard.css b/master/custom/static/dashboard.css index 94bd0af3..16148a28 100644 --- a/master/custom/static/dashboard.css +++ b/master/custom/static/dashboard.css @@ -1,7 +1,8 @@ .release_status { --none-color: #888; - background-color: white; + background-color: var(--card-color); + color: var(--text-color); border-radius: 10px; box-shadow: 0 4px 6px rgba(0, 0, 0, 0.1); padding: 20px; @@ -21,10 +22,10 @@ font-size: 87.5%; } a { - color: #007bff; + color: var(--link-color); text-decoration: none; &:hover { - color: #0056b3; + color: var(--link-hover-color); text-decoration: underline; } } @@ -144,7 +145,7 @@ .panel-body { padding: 10px; - background-color: white; + background-color: var(--background-color); text-align: center; flex-grow: 2; } @@ -251,28 +252,48 @@ border-radius: .25rem; margin-right: 1rem; background-color: var(--pill-bg-color); - border: 1px solid rgba(0, 0, 0, .2); + border: 1px solid var(--border-color); box-shadow: rgba(0, 0, 0, .2) 0px 1px 2px -1px inset; } } } } +/* When embedded in the Buildbot UI, its Light/Dark theme setting puts + --bb-* variables on ; follow them, with fallbacks for the page + served standalone (which follows the OS colour scheme instead). */ :root { - --primary-color: #306998; + --primary-color: var(--bb-link-color, #306998); --secondary-color: #FFD43B; - --background-color: #f4f4f4; - --text-color: #333; + --background-color: var(--bb-background-color, #f4f4f4); + --card-color: var(--bb-card-bg-color, white); + --text-color: var(--bb-text-color, #333); + --border-color: var(--bb-border-color, rgba(0, 0, 0, .2)); + --link-color: var(--bb-link-color, #007bff); + --link-hover-color: color-mix(in srgb, var(--link-color) 75%, var(--text-color)); --success-color: #4CAF60; --warning-color: #C2870F; --warning-color-bg: #E4B615; /* nicer "traffic light" amber , but not enough contrast for text */ --danger-color: #f44336; - --pill-bg-color: #e0e0e0; - --pill-text-color: #333; + --pill-bg-color: var(--bb-border-color, #e0e0e0); + --pill-text-color: var(--bb-text-color, #333); --pill-hover-bg-color: #306998; --pill-hover-text-color: #ffffff; } +@media (prefers-color-scheme: dark) { + :root { + --primary-color: var(--bb-link-color, #79b8e8); + --background-color: var(--bb-background-color, #1e1e2e); + --card-color: var(--bb-card-bg-color, #2a2a3c); + --text-color: var(--bb-text-color, #d4d4d8); + --border-color: var(--bb-border-color, #3a3a4c); + --link-color: var(--bb-link-color, #79b8e8); + --pill-bg-color: var(--bb-border-color, #3a3a4c); + --pill-text-color: var(--bb-text-color, #d4d4d8); + } +} + body { font-family: 'Arial', sans-serif; line-height: 1.6; From 7c824545e47ea35e64dff5dc566ae2973da1b4b9 Mon Sep 17 00:00:00 2001 From: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com> Date: Thu, 12 Nov 2026 15:32:26 +0200 Subject: [PATCH 2/4] More light/dark consistency fixes --- master/custom/static/dashboard.css | 17 +++++++++++------ 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/master/custom/static/dashboard.css b/master/custom/static/dashboard.css index 16148a28..ef4efaa1 100644 --- a/master/custom/static/dashboard.css +++ b/master/custom/static/dashboard.css @@ -209,16 +209,20 @@ height: 1rem; box-sizing: border-box; background-color: var(--pill-bg-color); - color: var(--pill-text-color); font-size: .75rem; line-height: 1rem; border-radius: .5rem; padding: 0 0 .4rem; text-align: center; vertical-align: .125rem; - &.build-results-success { background-color: var(--success-color); color: white; } + &.build-results-success { background-color: var(--success-color); } &.build-results-warning { background-color: var(--warning-color-bg); } - &.build-results-danger { background-color: var(--danger-color); color: white; } + &.build-results-danger { background-color: var(--danger-color); } + :is(#root, html) & { + color: var(--pill-text-color); + &.build-results-success, &.build-results-danger { color: white; } + &.build-results-warning { color: #333; } + } } .tag { display: inline-block; @@ -251,7 +255,7 @@ padding: .5rem; border-radius: .25rem; margin-right: 1rem; - background-color: var(--pill-bg-color); + background-color: var(--background-color); border: 1px solid var(--border-color); box-shadow: rgba(0, 0, 0, .2) 0px 1px 2px -1px inset; } @@ -265,8 +269,8 @@ :root { --primary-color: var(--bb-link-color, #306998); --secondary-color: #FFD43B; - --background-color: var(--bb-background-color, #f4f4f4); - --card-color: var(--bb-card-bg-color, white); + --background-color: var(--bb-background-color, #fff); + --card-color: var(--bb-card-bg-color, #f5f5f5); --text-color: var(--bb-text-color, #333); --border-color: var(--bb-border-color, rgba(0, 0, 0, .2)); --link-color: var(--bb-link-color, #007bff); @@ -283,6 +287,7 @@ @media (prefers-color-scheme: dark) { :root { + color-scheme: dark; --primary-color: var(--bb-link-color, #79b8e8); --background-color: var(--bb-background-color, #1e1e2e); --card-color: var(--bb-card-bg-color, #2a2a3c); From b097049a21beceab4191d65f31fd8dd9a34fba29 Mon Sep 17 00:00:00 2001 From: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com> Date: Thu, 12 Nov 2026 15:42:43 +0200 Subject: [PATCH 3/4] Refactor to use light-dark --- master/custom/static/dashboard.css | 37 ++++++++++++------------------ 1 file changed, 15 insertions(+), 22 deletions(-) diff --git a/master/custom/static/dashboard.css b/master/custom/static/dashboard.css index ef4efaa1..3be48220 100644 --- a/master/custom/static/dashboard.css +++ b/master/custom/static/dashboard.css @@ -264,38 +264,31 @@ } /* When embedded in the Buildbot UI, its Light/Dark theme setting puts - --bb-* variables on ; follow them, with fallbacks for the page - served standalone (which follows the OS colour scheme instead). */ + --bb-* variables on ; follow them, with light-dark() fallbacks for + the page served standalone (which follows the OS colour scheme instead). */ :root { - --primary-color: var(--bb-link-color, #306998); + --primary-color: var(--bb-link-color, light-dark(#306998, #79b8e8)); --secondary-color: #FFD43B; - --background-color: var(--bb-background-color, #fff); - --card-color: var(--bb-card-bg-color, #f5f5f5); - --text-color: var(--bb-text-color, #333); - --border-color: var(--bb-border-color, rgba(0, 0, 0, .2)); - --link-color: var(--bb-link-color, #007bff); + --background-color: var(--bb-background-color, light-dark(#fff, #1e1e2e)); + --card-color: var(--bb-card-bg-color, light-dark(#f5f5f5, #2a2a3c)); + --text-color: var(--bb-text-color, light-dark(#333, #d4d4d8)); + --border-color: var(--bb-border-color, light-dark(rgba(0, 0, 0, .2), #3a3a4c)); + --link-color: var(--bb-link-color, light-dark(#007bff, #79b8e8)); --link-hover-color: color-mix(in srgb, var(--link-color) 75%, var(--text-color)); --success-color: #4CAF60; --warning-color: #C2870F; --warning-color-bg: #E4B615; /* nicer "traffic light" amber , but not enough contrast for text */ --danger-color: #f44336; - --pill-bg-color: var(--bb-border-color, #e0e0e0); - --pill-text-color: var(--bb-text-color, #333); + --pill-bg-color: var(--bb-border-color, light-dark(#e0e0e0, #3a3a4c)); + --pill-text-color: var(--bb-text-color, light-dark(#333, #d4d4d8)); --pill-hover-bg-color: #306998; --pill-hover-text-color: #ffffff; -} -@media (prefers-color-scheme: dark) { - :root { - color-scheme: dark; - --primary-color: var(--bb-link-color, #79b8e8); - --background-color: var(--bb-background-color, #1e1e2e); - --card-color: var(--bb-card-bg-color, #2a2a3c); - --text-color: var(--bb-text-color, #d4d4d8); - --border-color: var(--bb-border-color, #3a3a4c); - --link-color: var(--bb-link-color, #79b8e8); - --pill-bg-color: var(--bb-border-color, #3a3a4c); - --pill-text-color: var(--bb-text-color, #d4d4d8); + /* Only when served standalone (the Buildbot UI mounts in #root), so the + UI's own theme is left alone: lets light-dark() and browser-drawn + chrome follow the OS colour scheme. */ + &:not(:has(#root)) { + color-scheme: light dark; } } From 847f2185764c0b02bab6973a0df85dbd78977cca Mon Sep 17 00:00:00 2001 From: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com> Date: Thu, 12 Nov 2026 16:13:46 +0200 Subject: [PATCH 4/4] Remove unused colour variables --- master/custom/static/dashboard.css | 3 --- 1 file changed, 3 deletions(-) diff --git a/master/custom/static/dashboard.css b/master/custom/static/dashboard.css index 3be48220..ea7cd536 100644 --- a/master/custom/static/dashboard.css +++ b/master/custom/static/dashboard.css @@ -268,7 +268,6 @@ the page served standalone (which follows the OS colour scheme instead). */ :root { --primary-color: var(--bb-link-color, light-dark(#306998, #79b8e8)); - --secondary-color: #FFD43B; --background-color: var(--bb-background-color, light-dark(#fff, #1e1e2e)); --card-color: var(--bb-card-bg-color, light-dark(#f5f5f5, #2a2a3c)); --text-color: var(--bb-text-color, light-dark(#333, #d4d4d8)); @@ -281,8 +280,6 @@ --danger-color: #f44336; --pill-bg-color: var(--bb-border-color, light-dark(#e0e0e0, #3a3a4c)); --pill-text-color: var(--bb-text-color, light-dark(#333, #d4d4d8)); - --pill-hover-bg-color: #306998; - --pill-hover-text-color: #ffffff; /* Only when served standalone (the Buildbot UI mounts in #root), so the UI's own theme is left alone: lets light-dark() and browser-drawn